add How_to_add_healthcheck_for_acp_clusters.md#56
Conversation
WalkthroughAdded a new solution document that describes configuring ALB VIP-based health checks for Alauda Container Platform (ACP) clusters, specifying the ALB health-check port (11782), recommended protocol (TCP), timeouts, intervals, unhealthy threshold, and VIP port-forwarding prerequisite. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Admin as Admin
participant ALB as ALB
participant VIP as VIP (optional)
participant Cluster as ACP Cluster
Admin->>ALB: Configure health check\n(Address, Port=11782, Protocol=TCP, Timeout=2s, Interval=5s, Unhealthy=3)
note over ALB: Port 11782 (global) or 1936 (business)
alt ALB via VIP
ALB->>VIP: TCP health probe
VIP->>Cluster: Port-forward to health port
Cluster-->>VIP: Health response
VIP-->>ALB: Health response
else Direct ALB to Cluster
ALB->>Cluster: TCP health probe
Cluster-->>ALB: Health response
end
note over ALB,Cluster: Interval: 5s • Timeout: 2s • Unhealthy threshold: 3
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (2)
docs/en/solutions/How_to_add_healthcheck_for_acp_clusters.md (2)
12-13: Rename section and fix “VIP” casingAlign with standard terminology.
-## Config Vip Health Check -Refer to the following table to configure the VIP health check parameters: +## Configure VIP health check +Refer to the following table to configure the VIP health‑check parameters:
22-22: Add a short security note1936 is commonly an admin/stats port; advise restricting exposure.
+> Note: Do not expose the health‑check ports publicly. Restrict access (ACLs/firewalls) and prefer TCP connect checks over HTTP to avoid leaking stats or admin endpoints.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/en/solutions/How_to_add_healthcheck_for_acp_clusters.md(1 hunks)
🔇 Additional comments (1)
docs/en/solutions/How_to_add_healthcheck_for_acp_clusters.md (1)
1-6: Front-matter schema: confirm iftitle:is required for solution docs
The front matter in docs/en/solutions/How_to_add_healthcheck_for_acp_clusters.md (and other solution guides) currently only listsproductsandkind. Please verify against our documentation or template whether atitle:key must be included.
8be1747 to
c08f74c
Compare
c08f74c to
d216b4b
Compare
Summary by CodeRabbit